-
Notifications
You must be signed in to change notification settings - Fork 7
Update references to 1.2 spec, re-ordering, content updates #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/ResearchObject/packaging_data_with_ro-crate/compare/md-outputs..md-outputs-PR-9 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-07-25 08:52:06 +0000 |
|
There is a validation failure in the new lesson file that my local build isn't picking up, I will get back to it tomorrow morning to troubleshoot. |
elichad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates @a-mile ! I've made some suggestions for clarity and such but on the whole these look like good changes.
Co-authored-by: Eli Chadwick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you renamed these three the wrong way round - this one should have become 04-root.md and so on (the content no longer matches the filename). I'll fix that and then merge
| } | ||
| ``` | ||
|
|
||
| :::::::::::::::::::::::::::::::::::::::: callout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this first time through, but I think we should move this section to where we add the metadata descriptor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a commit for this, hopefully it is not contentious :)
elichad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this now, thanks again @a-mile !
|
Merging now so we have plenty of time to check that all the changes show up correctly on the website |
Auto-generated via `{sandpaper}`
Source : c82ddf7
Branch : main
Author : Eli Chadwick <[email protected]>
Time : 2025-07-25 08:57:20 +0000
Message : Merge pull request #9 from a-mile/acm_rep_updates
Update references to 1.2 spec, re-ordering, content updates
Auto-generated via `{sandpaper}`
Source : a66e0ab
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-07-25 08:58:20 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : c82ddf7
Branch : main
Author : Eli Chadwick <[email protected]>
Time : 2025-07-25 08:57:20 +0000
Message : Merge pull request #9 from a-mile/acm_rep_updates
Update references to 1.2 spec, re-ordering, content updates
Auto-generated via `{sandpaper}`
Source : a66e0ab
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-07-25 08:58:20 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : c82ddf7
Branch : main
Author : Eli Chadwick <[email protected]>
Time : 2025-07-25 08:57:20 +0000
Message : Merge pull request #9 from a-mile/acm_rep_updates
Update references to 1.2 spec, re-ordering, content updates
This branch updates the tutorial to reference the 1.2 spec. It also addresses suggestions for updating content in preparation for the upcoming ACM Rep conference. These include: